Repository navigation
POC: fold the collection read gate into isLlmReadable - #4428
Closed
cursor[bot] wants to merge 5 commits into
Closed
cursor[bot] wants to merge 5 commits into
cursor[bot] wants to merge 5 commits into
Conversation
…secret fields (FIX-2436) readResource resolved a path against every registered collection and returned the full stored state, so a worker given resourceTools() beside a collection it may not show the model (a user's MCP keys) could read it. The read now reaches only a collection that opted in with llmReadable, the gate the content and search tools already apply, and drops the fields the collection names in secret. Any other path answers as one no collection matches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGRHaqqMGz8cJxCeoQ
…436) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGRHaqqMGz8cJxCeoQ
…k a consumer (FIX-2436) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGRHaqqMGz8cJxCeoQ
…ource (FIX-2436) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NczDiGRHaqqMGz8cJxCeoQ
The collection helper repeated the same config.llmReadable check. The exported gate now accepts a collection ref, so list, search, and readResource call it. Co-authored-by: Jake Hoffner <jhoffner@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 4 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not merge. It is a subtraction against #4426 (head
358ff502). Fold it into that PR, then close this unmerged.Subtracted
isCollectionLlmReadablerepeatedisLlmReadable(config.llmReadable === true). The exported gate now takes a resource ref or a collection ref. Listing, projected search, andreadResourcecall that one check.What a read returns is unchanged. Writes are untouched.
Still passes
packages/engine/test/resource-tools-path-matching.test.ts— 56 passedpackages/workforce/test/resource-tools-key-read.test.ts— 1 passedpnpm --filter @flow-state-dev/core exec tsc -p tsconfig.json --noEmit— cleanpackages/core/src/tools/resource-tools.ts— clean